carrillo-erik

Results 11 comments of carrillo-erik

Manually tested the `Volumes` functionality across the application and did not experience any issues. No issues with C/I pipelines. Overall it's a good refactor of the existing queries that will...

Tested the commands and was able to successfully execute them. There was a warning message, I'll paste here for your attention: ``` WARNING: Secure coding is not enabled for restorable...

I was able to run the tests locally without issues. All 6 tests are passing ✅ ![Screenshot 2023-11-08 at 3 25 15 PM](https://github.com/linode/manager/assets/119514965/44a2d078-0ab7-41ef-af8c-6235d62f2228)

@cliu-akamai I was able to run this locally and after running the tests I did not see the test failing. I re-started the end-to-end test in the Jenkins UI and...

> 1. The placement_group payload is still sent when the flag is OFF, which we want to avoid @abailly-akamai This makes sense, however, if the feature flag is OFF; should...

@jdamore-linode Awesome work! This should help alleviate some of the issues and improve developer experience. Looks like you've got some merge conflicts to resolve.

#### Please Note: Aside from resolving the merge conflicts, there's some optimizations that need to be implemented. There were additional use cases discovered and I'm waiting for input from UX...

@abailly-akamai @mjac0bs There's been a few updates to this PR and it continually got bigger (although the changes were minimal). I'm more than happy to schedule a pair review session...

> @carrillo-erik you have to fix conflicts and address feedback before this gets out of date again @abailly-akamai I've pushed my recent changes addressing the feedback.

@mjac0bs > There's one more failure that is legit and a result of these changes: `security-questions.spec.ts`. It's still looking for the enhanced select. I've fixed the issue with the test...