carr
Refactor: deals with countries with the same code
- creates
iso_countries.ymlsuch that the key is the country's ISO code (e.g. CA) - updates the tests accordingly
- introduces some helper methods
- loads countries if not loaded (thus not requiring the developer to that by himself!)
- introduces Canada
@jimbomt, thanks for the PR. I can't take it as it stands though - it changes too much at once. Having said that, I like using Carmen to get iso data and we do need to come up with a way to organized the country data outside of the country code. No doubt I will use some of what you have here and make sure to give you credit!
I'll let you know when these bits are brought in. Thanks again!
I don't want to just shut you down. I'd like to expand on my "changes too much at once" comment. Your pull request does the following that really have nothing to do with the core issue:
- adds personal project preferences to the .gitignore
- changes the development ruby version
- changes some spacing in support.rb, which was removed today by the way:)
- changes the gem version
If you are planning on contributing to this and other projects then you should be careful not to include extraneous changes like these when adding a fix. Of particular note is changing the version of the gem, that is usually handled by the maintainers of a project. What you can do is suggest that the version be modified as a result of the changes. For instance, in this case, I have been working on v1.3.0 for a while and wouldn't likely include such a large update in the same version - I might rev to 1.4 or something.
Hi @elskwid. Sorry for my very very late reaction to this! You are totally right about the specific project preferences and I'll make sure to clean them up.
As regards the yml/index, don't you thing that conceptually it makes more sense to have the ISO country codes as fields? Using phone area codes leads to clashes between countries (Canada and US being the obvious two). I understand it's a pretty significant change architecturally but the API is backwards-compatible (it only adds new features, rather).
How would you like to proceed with it? Or rather, is there already a version where all countries are supported? I have been too busy to keep track lately. Thanks for the feedback!
