styles icon indicating copy to clipboard operation
styles copied to clipboard

Use submodule

Open rgaiacs opened this issue 6 years ago • 1 comments

As I mentioned at the maintainers mailing list, I want to use submodules because change bin/lesson_initialize.py involves lots of rebase and send the changes to the lessons is even harder. For a example, see https://github.com/swcarpentry/lesson-example/pull/132. This is related with a talk/demo that @jduckles gave early this year.

@IanLee1521 made a similar suggestion here so I decided to create this issue as a place of discussion.

Notes from old discussion with @jduckles

  • GitHub Pages will pull submodules when building the website.
  • Update the style would only require to change the commit id that is being pulled.
  • Changes on style that are backward incompatible can cause the website to not be build properly or not be build at all.
  • Instructors change on their own copy of style would require a multi step process: (1) create their own copy of styles, (2) push their changes to their own copy of styles, (3) change the commit id that GitHub Pages will be pull.

rgaiacs avatar Oct 19 '17 08:10 rgaiacs

FWIW, I'm actually more partial to sub trees, rather than sub modules, but that's just me.

IanLee1521 avatar Oct 19 '17 16:10 IanLee1521