sandpaper icon indicating copy to clipboard operation
sandpaper copied to clipboard

ENH: Fix `Node.js` warnings linked to GitHub actions

Open jhlegarreta opened this issue 1 year ago • 3 comments

Fix Node.js warnings linked to GitHub actions: bump versions actions/checkout@v4, actions/cache@v4, and actions/upload-artifact@v4

Fixes:

Update Workflow
Node.js 16 actions are deprecated.
Please update the following actions to use Node.js 20:
actions/checkout@v3, carpentries/create-pull-request@main.
For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

raised for example in: https://github.com/carpentries-incubator/SDC-BIDS-fMRI/actions/runs/9753104282

Please delete this line and the text below before submitting your contribution.


Thanks for contributing!

Please keep in mind that lesson maintainers are volunteers and it may be some time before they can respond to your contribution. Although not all contributions can be incorporated into the lesson materials, we appreciate your time and effort to improve the curriculum. If you have any questions about the lesson maintenance process or would like to volunteer your time as a contribution reviewer, please contact The Carpentries Team at [email protected].


jhlegarreta avatar Jul 02 '24 13:07 jhlegarreta

Not sure if

  • The warning in https://github.com/carpentries-incubator/SDC-BIDS-fMRI/actions/runs/9753104282/job/26917817957#step:4:22
  • The error in https://github.com/carpentries-incubator/SDC-BIDS-fMRI/actions/runs/9753104282/job/26917817957#step:4:516

are relevant to this repository.

jhlegarreta avatar Jul 02 '24 13:07 jhlegarreta

I've opened this as well: https://github.com/carpentries/create-pull-request/pull/1

But the main branch is 200 commits behind the upstream repository, so it is probably a good idea to sync the repository with the upstream.

jhlegarreta avatar Jul 02 '24 14:07 jhlegarreta

Also related https://github.com/carpentries/actions/pull/94

jhlegarreta avatar Jul 02 '24 14:07 jhlegarreta

Thanks @jhlegarreta for these fixes. Sorry this took a while to get to, but these look good to me!

ErinBecker avatar Aug 23 '24 15:08 ErinBecker