lesson-example icon indicating copy to clipboard operation
lesson-example copied to clipboard

Replace .gitkeep files with useful explanation of folder purpose

Open katrinleinweber opened this issue 6 years ago • 4 comments

As discussed in #234. make serve is not impacted in any way that I notice. Is the initial text in the ReadMe.md files factually correct?

katrinleinweber avatar Nov 02 '18 14:11 katrinleinweber

The build error does not seem to be related to these changes:

In library(package, lib.loc = lib.loc, character.only = TRUE, logical.return = TRUE,  :
  there is no package called ‘requirements’

katrinleinweber avatar Nov 04 '18 09:11 katrinleinweber

The relevant build error is:

Error in i.p(...) : 
  (converted from warning) 'lib = "/usr/local/lib/R/site-library"' is not writable"

it is triggered because the Travis file is not set up for R (only Python), and hence the environment variables and library aren't set up to allow package installation.

fmichonneau avatar Nov 05 '18 21:11 fmichonneau

OK, thanks for explaining. Please feel free to hide my above comment about the resulting error.

Let's focus on the suggested changes again.

katrinleinweber avatar Nov 06 '18 06:11 katrinleinweber

I found a possibly even cleaner way to avoid (almost) empty folders:

image

What do you think @rgaiacs & @fmichonneau? Since the makefiles of both lesson-example and styles have the same commit history, I guess such commits should be PR'ed towards the styles repo.

Also: Happy new year, and all the best for 2019 :-)

katrinleinweber avatar Jan 02 '19 20:01 katrinleinweber