docs.carpentries.org icon indicating copy to clipboard operation
docs.carpentries.org copied to clipboard

Set up glossary

Open maneesha opened this issue 8 months ago • 8 comments

Sets up glossary in handbook. See issue #94.

maneesha avatar Apr 04 '25 15:04 maneesha

Deploy Preview for carpentries-handbook ready!

Name Link
Latest commit
Latest deploy log https://app.netlify.com/sites/carpentries-handbook/deploys/6821f505d9a98742292ab65c
Deploy Preview https://deploy-preview-339--carpentries-handbook.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Apr 04 '25 15:04 netlify[bot]

I have left some questions in issue #94

maneesha avatar Apr 04 '25 17:04 maneesha

@maneesha are you still waiting for feedback from @OscarSiba ?

elletjies avatar Apr 07 '25 06:04 elletjies

@elletjies Yes, I am waiting on feedback but I just put this up on Friday and it's only Monday now.

maneesha avatar Apr 07 '25 10:04 maneesha

Thanks - wanted to know if I need to review now or wait for Oscar.

elletjies avatar Apr 07 '25 11:04 elletjies

Thank you @maneesha as always for spotting these errors. I would like to make the changes you suggest, but given how extensive some are (moving around large chunks of texts), should I rather do that on the dev. site? Seems as if I can only do a line-by-line edit here if I'm reviewing.

OscarSiba avatar Apr 08 '25 20:04 OscarSiba

  1. In this PR, click on the "Files Changed" tab and go to the glossary file.
  2. Near the top right of the file preview, click on the three dots and select "Edit file"
  3. You will now see the whole file in editing mode. You can now copy/paste text and make other edits.
  4. Once you make the change, click the green "Commit changes..." button near the top right.
  5. Give it a good commit message (such as "updated definition of discussion host") and commit directly to the glossary-94 branch.

You can make all the changes at once, or you can make changes one at a time and repeat the steps above for each one. Happy to set some co-working time if you want to do this together.

maneesha avatar Apr 09 '25 10:04 maneesha

I think I tried what you are suggesting @maneesha but I don't seem to have the option to edit the whole file: image

It seems I can only do line by line edits, and these are harder to make for me in this way if moving large chunks of text around.

Co-working time would be great, please and thank you, here is my Calendly: https://calendly.com/oscar-masinyana-carpentries/30min?month=2025-04

OscarSiba avatar Apr 10 '25 10:04 OscarSiba

Leaving note here that we reviewed this together on 2025-04-07 and Oscar was able to edit the file as needed.

maneesha avatar Apr 30 '25 12:04 maneesha

@elletjies do you still have input you'd like to make to this before Maneesha merges it?

OscarSiba avatar May 12 '25 09:05 OscarSiba

@OscarSiba I made two suggestions

elletjies avatar May 12 '25 09:05 elletjies

I added in the change to British spelling ("customised")

Failing checks are on Netlify's end so this should be OK to merge.

maneesha avatar May 12 '25 13:05 maneesha