Admin can add multiple signups for the same Instructor at the same workshop

[elichad]

An Instructor can only sign up to help at a workshop once. However, an admin can add more signups for that same Instructor. This has potential to create confusion if the states are changed for both signups.

Trying to confirm both causes a database error (#2449), but accepting one and declining the other means different emails will be sent and different status will be shown to the Instructor depending on the order of those actions.

The correct action would be to delete the duplicate, but we should make it harder to run into this problem in the first place.

[maneesha]

Thanks for catching this @elichad. I agree that the fix should be to prevent the admin from creating duplicate signups.

[maneesha]

Some other questions/notes:

• In addition to different emails being sent out if the admin accepts one and declines the other, what happens to the instructor task that gets created?
• Can an admin create a signup if the Instructor has already created their own signup? If so, this should be prevented as well.
• If the signup was created by the admin and not the instructor, can we have some way of indicating that in the view?

[maneesha]

From Eli: If you accept and then decline, it creates instructor task and schedules "accepted" email; then deletes the instructor task and schedules "declined" email.
If you do it the other way around - need to check what happens.

[maneesha]

If the signup was created by the admin and not the instructor, can we have some way of indicating that in the view?

Eli: Not sure if we track who creates the signup. Could have admin add this to notes (but relies on the human)

[maneesha]

Eli: This should be relatively easy to do, with a unique constraint or a check when signup is created.