python-aos-lesson icon indicating copy to clipboard operation
python-aos-lesson copied to clipboard

Capturing small changes

Open JimCircadian opened this issue 1 year ago • 2 comments

As we're running this lesson next week, I'm doing a review at present and noticing a couple of small improvements. I'll update the list as I work through things and submit another PR

  • [ ] print(dset['pr']) does not provide the output given for attributes (it gets truncated if using the python REPL) so can add a call to pprint to overcome this consistently - applies to 02 and 08
  • [ ] Be nice to show the default dask dashboard for monitoring computations / building intuition in the large data lesson (and it's easily added to content)
  • [x] logging.critical is referred to as critcal (missing an i)

JimCircadian avatar Jan 04 '24 18:01 JimCircadian

Thanks, @JimCircadian. Always good to have someone new check over the materials closely.

Is the workshop at/for the British Antarctic Survey. In the README I try and keep track of where the lessons are getting used.

DamienIrving avatar Jan 04 '24 21:01 DamienIrving

Thanks, @JimCircadian. Always good to have someone new check over the materials closely.

Is the workshop at/for the British Antarctic Survey. In the README I try and keep track of where the lessons are getting used.

Yes indeed, we're using this at the British Antarctic Survey!

JimCircadian avatar Jan 05 '24 21:01 JimCircadian