machine-learning-novice-sklearn icon indicating copy to clipboard operation
machine-learning-novice-sklearn copied to clipboard

Github actions to check lesson builds

Open colinsauze opened this issue 4 years ago • 5 comments

There should be some github actions to check the lesson builds correctly and passes make lesson-check.

Examples on doing this available from: https://github.com/carpentries-incubator/template/tree/gh-pages/.github/workflows

colinsauze avatar Jun 28 '21 17:06 colinsauze

This lesson doesn't pass the website action check because there is no Gemfile. You can get it from https://github.com/carpentries/styles.

maxim-belkin avatar Jun 29 '21 20:06 maxim-belkin

Thanks @maxim-belkin but its still failing to run lesson-check, any ideas why?

colinsauze avatar Jul 07 '21 16:07 colinsauze

This check indicates that lesson-check is passing (albeit with warnings), am I missing anything?

vinisalazar avatar Jul 07 '21 16:07 vinisalazar

Thanks @maxim-belkin but its still failing to run lesson-check, any ideas why?

I do see the reason (explained below) but I'm pretty sure make lesson-check-all should not fail no matter what. I'll fix that (in carpentries/styles).

Explanation: make lesson-check-all currently fails because all lines in 05-dimensionality-reduction.md are empty. If you add even a single dot or an empty HTML comment <!-- --> -- it'll succeed. PR #21 adds some text there, so the check passes there

maxim-belkin avatar Jul 07 '21 16:07 maxim-belkin

I've just seen that error about dimensonality-reduction missing a blank line too. I was expecting it to appear if you expanded the "Run make lesson-check all" section, but I just see it saying (in red) "Error: ". But when I view the raw logs by pressing the 3 dots at the top of the check screen I can see that error.

colinsauze avatar Jul 07 '21 16:07 colinsauze