pickle icon indicating copy to clipboard operation
pickle copied to clipboard

No permission dialog on iOS11 when permission is denied

Open daveluong opened this issue 7 years ago • 5 comments

Steps to reproduce

Go to Device Settings Select Pickle Example Select Photos, Select "Never" Then, launch Pickle Example Select any Here, you will see the old image picker format, even though you do not give Picker Example access to Photos.app Then, select a photo You will see a blank page that is unresponsive, requiring you to kill app

Actual outcome unresponsive page

Expected outcome If access to Photos is disabled, client should show a page that informs you that access is required before proceeding to Sell Form. See attached image for what the prompt is on production for iOS10 and below


Upon initial investigation, it appears to be bug in UIImagePicker in iOS11.

daveluong avatar Oct 03 '17 10:10 daveluong

Is there any plan to work around this issue or to replace the permission denied screen?

bcylin avatar Oct 03 '17 11:10 bcylin

No concrete plan at the moment. I think we will continue observing, if it escalates we might need to handle the denied state using custom view instead pf relying on UIImagePickerController

daveluong avatar Oct 03 '17 11:10 daveluong

@bcylin What is the reason that we're showing UIImagePickerController when the permission is case .denied, .restricted: ?

daveluong avatar Oct 05 '17 08:10 daveluong

Proposed fix:

Solution 1: Add 1 more function to ImagePickerDelegate that call delegate when permission status is .denied or .restricted and let delegate handle it on their own

Solution 2: Create a custom view to show permission error within Pickle instead of relying on UIImagePickerViewController

daveluong avatar Oct 05 '17 08:10 daveluong

It was because of the product design. It shows the system message when the permission is not granted.

bcylin avatar Oct 05 '17 08:10 bcylin