apprise
apprise copied to clipboard
Plivo Support
New Service Completion Status
- [x] apprise/plugins/NotifyPlivo.py
- [x] setup.py
- add new service into the
keywords
section of thesetup()
declaration
- add new service into the
- [x] README.md
- add entry for new service to table (as a quick reference)
- [x] packaging/redhat/python-apprise.spec
- add new service into the
%global common_description
- add new service into the
Checklist
- [ ] The code change is tested and works locally.
- [x] There is no commented out code in this PR.
- [x] No lint errors (use
flake8
) - [x] 100% test coverage
Syntax
-
plivo://{auth_id}@{token}/{from_phoneno}
-
plivo://{auth_id}@{token}/{from_phoneno}/{to_phoneno}
-
plivo://{auth_id}@{token}/{from_phoneno}/{to_phone_no}/{to_phone_no2}/{to_phone_noN}/
Testing
Anyone can help test this source code as follows:
# Create a virtual environment to work in as follows:
python3 -m venv apprise
# Change into our new directory
cd apprise
# Activate our virtual environment
source bin/activate
# Install the branch
pip install git+https://github.com/caronc/apprise.git@plivo-support
# Test out the changes with the following command:
apprise -t "Test Title" -b "Test Message" \
"plivo://auth@token/555-555-5555"
Codecov Report
Merging #143 into master will not change coverage. The diff coverage is
100%
.
@@ Coverage Diff @@
## master #143 +/- ##
======================================
Coverage 100% 100%
======================================
Files 57 58 +1
Lines 6653 6760 +107
Branches 1052 1065 +13
======================================
+ Hits 6653 6760 +107
Impacted Files | Coverage Δ | |
---|---|---|
apprise/plugins/NotifyPlivo.py | 100% <100%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 4ff48cb...dd097b6. Read the comment docs.
Plivo support placed on hold due to upstream restrictions.
I'm specifically looking for details on the {auth_id} and {auth_token}; information such as knowing if it's alpha/numeric characters that accepts dashes, how many characters are expected, etc. Usually I'd have just make an account and figure this out for myself (since this info is passed right to me). An account would allow me to even test everything, but unfortunately i can't...
Plivo does not allow you to sign up with their service using a @gmail.com
email account. I reached out to support asking for permission and explaining how I'd like to add them to this tool.... Here is their response:
If anyone has an account and is willing to just share me the {auth_id} and {auth_token} structure (not your account personal details) allowing me to complete this pull request, that would be awesome! :slightly_smiling_face:
The PR is pretty much completed already and would require very subtle changes to get going once the missing details are known.
Codecov Report
Merging #143 into master will not change coverage. The diff coverage is
100%
.
@@ Coverage Diff @@
## master #143 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 71 72 +1
Lines 8323 8419 +96
Branches 1333 1346 +13
=====================================
+ Hits 8323 8419 +96
Impacted Files | Coverage Δ | |
---|---|---|
apprise/plugins/NotifyPlivo.py | 100% <100%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 408810d...bbd60ee. Read the comment docs.
Maybe if Plivo support was easier to implement, they'de get more customers :dancers: :)
Maybe this issue can be revisited? Ideally, we may find someone from @Plivo who likes Apprise to gain corresponding support and who would endorse this in a positive way. It would be so sweet.
/cc @narayana-plivo, @kalyan-plivo
@amotl sure we will check and get back to you soon.
Codecov Report
Patch coverage: 100.00
% and no project coverage change.
Comparison is base (
1e30be3
) 100.00% compared to head (eb3e162
) 100.00%.
:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@ Coverage Diff @@
## master #143 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 118 119 +1
Lines 15572 15672 +100
Branches 3173 3188 +15
==========================================
+ Hits 15572 15672 +100
Impacted Files | Coverage Δ | |
---|---|---|
apprise/plugins/NotifyPlivo.py | 100.00% <100.00%> (ø) |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Rebased code with master since this branch was really outdated (and with merge conflicts).
From my account, so one data point: {auth_id} is 20 characters {auth_token} is 40 characters Both alphanumeric, no dashes or other special characters.
@tombii would love it if you could give it another shot! :slightly_smiling_face: