Carol (Nichols || Goulding)

Results 136 comments of Carol (Nichols || Goulding)

> I have added T-core in the interim. We might want to fix this before a team triages this RFC. Because the libs and moderation teams are mentioned in the...

Adding another use case: when the type of the `source` error is a trait's associated type. It'd be nice to not need the `.map_err(|e| Box::new(e) as _)`, but I don't...

I don't think the main book is a great place for this content, as the target audience for TRPL is anyone wanting to write any code in Rust, while this...

Awesome, thanks! Found another spot related to extern crates-- this should also be updated when `cargo fix` handles that: https://github.com/rust-lang-nursery/edition-guide/blame/master/src/rust-2018/module-system/path-clarity.md#L62-L63

Sorry, I don't have much context here about what you'd like to know... what about heroku are you not sure? The performance of database queries? The performance of web requests?...

Aha, i see. Yes, crates.io does have a local checkout of the git repo on heroku -- [this code](https://github.com/rust-lang/crates.io/blob/master/src/bin/server.rs#L22) sets it up. GIT_REPO_CHECKOUT is set to `/app/tmp/index-checkout` on crates.io and...

[Here's the official heroku docs](https://devcenter.heroku.com/articles/dynos#ephemeral-filesystem)

@russmack yes, the mailmap should take care of that https://github.com/steveklabnik/rust/commit/0f2a5f686f3fbc3d66dce301e965b43d5c3acd63

I see what you mean; I think I like "might" here instead of "can". Could you make that change please?

No need to ping me, I will get to this when I get to it and pinging will not increase its priority, thank you