carmen-rails icon indicating copy to clipboard operation
carmen-rails copied to clipboard

Rails support for Rails 4.2

Open jtapia opened this issue 9 years ago • 5 comments

  • Update gems
  • Update Ruby and Rails versions
  • Update README

jtapia avatar May 01 '15 16:05 jtapia

It's still failing because it thinks the Gemfile has been changed. I'm not sure why, but it would be nice to see if it's reproducible on your local dev environment.

I would take out updating the version. I think it's best to keep the feature change independent of incrementing the version so features can be reverted without affecting the version number.

ecbypi avatar May 01 '15 18:05 ecbypi

@ecbypi got it, and done, I removed the update of version

jtapia avatar May 01 '15 18:05 jtapia

I can't reproduce it locally, and neither send the new Gemfile.lock, because maybe we're using different versions

jtapia avatar May 01 '15 18:05 jtapia

@jtapia, found another instance of the bundler problem. Searching through bundler's issues, I'm able to find issues with a similar error message, but nothing that exactly mirrors our problem. I'm trying to run the build with an updated version of bundler.

http://stackoverflow.com/questions/26221540/gemspec-modification-up-to-date-gemfile-lock-does-break-the-travis-ci-build-d

ecbypi avatar May 13 '15 13:05 ecbypi

@ecbypi Ok, let me take a look and see if I can find a solution, is it for Travis CI, right?

jtapia avatar May 13 '15 16:05 jtapia