Carl Wiedemann
Carl Wiedemann
> potential unknown compatibilities and bugs because of big changes that are not supposed to be breaking but carry the risk To be clear: This risk exists at all times,...
Friendly bump. Is there anything preventing this from getting merged?
I'd suggest re-opening this issue. The problem here is that the behavior contracts the documentation. In the README, [it shows the following example](https://github.com/sinatra/sinatra#error), acting as a catch-all for any error....
I should be more specific: The behavior depends on `:raise_errors` config option. If `:raise_errors` is `true`, then the catch-all works as described. Otherwise, it does not work as described.
I added https://github.com/sinatra/sinatra/pull/1914 as an example
> Isn't https://github.com/sinatra/sinatra/pull/1914 showing the opposite? Sorry, let me explain what I meant. I was trying to say that when `raise_errors` is true, that the problem as originally described by...
> I'm starting to think the existing behaviour is the intentional behaviour and not a bug (you want your tests to raise errors even if you have a catch all...
If that is the official case, then it seems worth documenting. Do you agree? Reading more about the initial change that I posted above it says the following in 4e71959:...
Ok, I opened https://github.com/sinatra/sinatra/pull/1917 for a potential doc update.
Thanks for the quick response here, folks. I'll check-in with my coworker after she's back from vacation and the end of the week to make sure that we're good, then...