django-filter icon indicating copy to clipboard operation
django-filter copied to clipboard

Published 20 hours ago • verified publisher icon carltongibson

fix #1475 - filter_overrides extra now applied when field has choices

Open Spycho opened this issue 3 years ago • 4 comments

Code change compatible with older python versions ({**a, **b} rather than a | b used for combining dictionaries), as I spotted via running tox on your project it wants to run back to 3.6.

Test added for this case, checked it fails without the change, passes with.

Closes #1475

Spycho avatar Feb 09 '22 22:02 Spycho

It would be great to get this merged and released @carltongibson so we can stop depending on my fork.

Spycho avatar May 10 '22 16:05 Spycho

@Spycho 👍 DF is on the list for a dust-off and release after Django 4.1a1, so I shall give it a look then. Thanks.

carltongibson avatar May 10 '22 18:05 carltongibson

... I spotted via running tox on your project it wants to run back to 3.6.

We'll be dropping support for PY36, and Djangos<3.2 if you fancy making those adjustments? 🙂

carltongibson avatar May 10 '22 18:05 carltongibson

Happy to, but wouldn't it be best to merge this in as is, as it works with all versions, and then refactor to use the new dictionary combining syntax after you've dropped 3.6 support?

Spycho avatar May 10 '22 21:05 Spycho