Carlton Gibson comments

Results 1070 comments of


                                            Carlton Gibson

Catch JSONField error to prevent not being able to show the response data

Hi @loeeess — thanks for the report. So I think a `FilterSet` option to do one of three things when encountering an unknown field type is the way forward here:...

Catch JSONField error to prevent not being able to show the response data

@loeeess Great work thanks. I left an initial comment. Let's carry on there. 👍

Catch JSONField error to prevent not being able to show the response data

Fixed in #1675. Thanks @loeeess

add Python 3.13 and Django 5.1 support + remove deprecated versions

Well, if you're actual do due diligence... 😅 Not sure how to smooth that. Maybe a warnings test run with `-Werror`, but beyond that, yes you'd need to read. I...

Support group mappings as dictionares introduced in Django 5.0

Fancy making a PR @saevarom ?

Support group mappings as dictionares introduced in Django 5.0

Great. Have fun! 🥳

Fix grouped choices as dict

Oh, except the tests didn't like it...

Fix grouped choices as dict

@saevarom I'm looking towards a release. Do you have time to address the failing test on Django 4.2?

Fix grouped choices as dict

@saevarom great thanks. The isort run is playing up. I can look at that later on. Other than that :+1:

Fix grouped choices as dict

> django_filters/filters.py:34:5: F401 'django.utils.choices.BaseChoiceIterator' imported but unused