python-audio-effects icon indicating copy to clipboard operation
python-audio-effects copied to clipboard

Verify Windows and Mac support

Open carlthome opened this issue 8 years ago • 7 comments

carlthome avatar Sep 23 '16 16:09 carlthome

Windows install works fine with https://github.com/carlthome/python-audio-effects/commit/6928888f3ee045e426166878f8176fba07517b04 but some extra install steps are required, such as conda install -c conda-forge resampy and having to install sox with the official installer and adding both it as well as the Windows ffmpeg release manually to PATH.

carlthome avatar Oct 18 '16 21:10 carlthome

Could someone with OS X run python setup.py test as well so this issue can be closed?

carlthome avatar Oct 18 '16 21:10 carlthome

Actually, nevermind: https://github.com/carlthome/python-audio-effects/commit/abb9e5ac9c835f2c818004cf0eeac67284282e78

carlthome avatar Oct 18 '16 21:10 carlthome

Seems Travis's OS X support is a bit too fresh. The builds fail on silly stuff like not being able to unpack a tar: https://travis-ci.org/carlthome/python-audio-effects/jobs/168943133

carlthome avatar Oct 19 '16 16:10 carlthome

https://github.com/carlthome/python-audio-effects/pull/18

carlthome avatar Oct 12 '18 13:10 carlthome

Could someone with OS X run python setup.py test as well so this issue can be closed?

Screenshot 2021-01-23 at 15 26 07

jootd avatar Jan 23 '21 11:01 jootd

Thanks for checking, @DataKhukhua! Looks like the tests aren't picked up by that command. Could you run pytest directly instead as in https://github.com/carlthome/python-audio-effects/blob/master/.github/workflows/test.yml#L38 (if you have time to spare)?

I should also just learn how to setup CI testing for all major OS:s at some point in my life. :panda_face:

carlthome avatar Jan 25 '21 09:01 carlthome