Determine the nature of two test classes

[mslowiak]

Task Description

We have in project two classes:

• NewAsynchronousFileChannelTestIT
• NewByteChannelIT

The classes are annotated with integration test annotation and extending S3UnitTestBase.

Tasks

The following tasks will need to be carried out:

• [ ] We should determine if that test classes are either unit tests or integration tests and mark them appropriately.

Task Relationships

This task:

• Depends on: #184
• Relates to: #183, #103

Help

• Our chat channel
• Points of contact:
  • @carlspring
  • @ptirador
  • @steve-todorov

[steve-todorov]

After doing some digging for #199, I can say these two tests are for sure integration tests as they are creating resources in the S3 buckets. The class name S3UnitTestBase is definitely confusing and we should maybe make it something like abstract S3BaseTest extends BaseTest. I'm not 100% sure about the naming yet though.

// cc @carlspring

[carlspring]

The name S3UnitTestBase does not intuitively imply that this is an integration test-related class. We should have a base test clas for integration tests. We can call it something along the lines of S3IntegrationTestBase.

[steve-todorov]

Actually I forgot we now have BaseIntegrationTest since #183 and #186. We could probably move these methods there and remove S3UnitTestBase ?

[carlspring]

Yes, it would make more sense.