add-to-calendar-buttons icon indicating copy to clipboard operation
add-to-calendar-buttons copied to clipboard

Published 20 hours ago • verified publisher icon carlsednaoui

IE8 compatibility

Open marcovtwout opened this issue 11 years ago • 11 comments

IE8 is still widely used, unfortunately your plugin is not compatible ;)

I found the following errors:

  • Function does not exist https://github.com/carlsednaoui/add-to-calendar-buttons/blob/master/ouical.js#L5
  • Runtime error: https://github.com/carlsednaoui/add-to-calendar-buttons/blob/master/ouical.js#L117 (solution: http://stackoverflow.com/questions/6631871/modifying-the-innerhtml-of-a-style-element-in-ie8)
  • Function forEach does not exist https://github.com/carlsednaoui/add-to-calendar-buttons/blob/master/ouical.js#L135

Would you care about fixing those?

marcovtwout avatar Feb 06 '14 10:02 marcovtwout

After patching these myself, I also found the "hack" where you use a checkbox to hide/show calendar items also does not work in IE8..

marcovtwout avatar Feb 06 '14 11:02 marcovtwout

Hey Marco,

Did you end up finding an alternative or solution for IE8?

mchandleraz avatar Apr 17 '14 00:04 mchandleraz

Hi @mchandleraz, I'm actually re-writing this library from the ground up. That should hopefully help take care of that nasty bug.

Branch with work in progress: https://github.com/carlsednaoui/add-to-calendar-buttons/tree/refactor

As a side note, @marcovtwout mentioned that he ended up patching the errors himself. Perhaps he can share the end result :)

carlsednaoui avatar Apr 17 '14 02:04 carlsednaoui

If you are rewriting this library, my patches shouldn't be needed. :)

Just take a close look at any javascript functions you are using and if they are supported by your target browsers. I recommend following the MDN documentation, for example: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/forEach

marcovtwout avatar Apr 17 '14 08:04 marcovtwout

@marcovtwout I know that, was just trying to save @mchandleraz some time. (Won't be a few weeks until the new version is out.)

carlsednaoui avatar Apr 17 '14 11:04 carlsednaoui

@marcovtwout @carlsednaoui thanks for the replies. I ended up just dropping the add to calendar feature from this project for this version because we were running out of time. I'll keep my eye on the new library though.

mchandleraz avatar Apr 19 '14 22:04 mchandleraz

I'm looking forward to the new version, too :+1:

ptim avatar Jun 01 '14 03:06 ptim

Sorry for the slack on this, been busy with https://github.com/carlsednaoui/ouibounce and other projects :cry: Will definitely put some hours into the new version soon!

carlsednaoui avatar Jun 02 '14 01:06 carlsednaoui

As requested, here is my patched and unsupported version created one year ago: http://pastebin.com/JeC9etZc

marcovtwout avatar Mar 13 '15 14:03 marcovtwout

@marcovtwout could you please send a PR?

carlsednaoui avatar Mar 13 '15 16:03 carlsednaoui

Sorry, as I said earlier, I really just patched things quickly, I don't think it is PR worthy.

marcovtwout avatar Mar 16 '15 08:03 marcovtwout