laracasts-downloader icon indicating copy to clipboard operation
laracasts-downloader copied to clipboard

Support PHP8

Open kossa opened this issue 3 years ago • 2 comments

Hello,

Getting some error when using PHP8


====================================
Authenticating
====================================
PHP Deprecated:  Function libxml_disable_entity_loader() is deprecated in /Users/mac/code/laracasts-downloader/vendor/symfony/dom-crawler/Crawler.php on line 162

Deprecated: Function libxml_disable_entity_loader() is deprecated in /Users/mac/code/laracasts-downloader/vendor/symfony/dom-crawler/Crawler.php on line 162
PHP Deprecated:  Function libxml_disable_entity_loader() is deprecated in /Users/mac/code/laracasts-downloader/vendor/symfony/dom-crawler/Crawler.php on line 182

Deprecated: Function libxml_disable_entity_loader() is deprecated in /Users/mac/code/laracasts-downloader/vendor/symfony/dom-crawler/Crawler.php on line 182
> Successfull!

====================================
Starting Collecting the data
====================================
PHP Deprecated:  Function libxml_disable_entity_loader() is deprecated in /Users/mac/code/laracasts-downloader/vendor/symfony/dom-crawler/Crawler.php on line 162

Deprecated: Function libxml_disable_entity_loader() is deprecated in /Users/mac/code/laracasts-downloader/vendor/symfony/dom-crawler/Crawler.php on line 162
PHP Deprecated:  Function libxml_disable_entity_loader() is deprecated in /Users/mac/code/laracasts-downloader/vendor/symfony/dom-crawler/Crawler.php on line 182

Deprecated: Function libxml_disable_entity_loader() is deprecated in /Users/mac/code/laracasts-downloader/vendor/symfony/dom-crawler/Crawler.php on line 182

kossa avatar Nov 27 '20 07:11 kossa

symfony dom-crawler 5.2 will fix it.

https://github.com/symfony/dom-crawler/commit/702ee651db23dc452bf1fd6dea6ca2f671ed2681

mouson avatar Nov 27 '20 07:11 mouson

Currently it uses "2.8.x-dev" https://github.com/carlosflorencio/laracasts-downloader/blob/master/composer.lock#L513

kossa avatar Nov 27 '20 07:11 kossa

Working fine here with PHP 8.2. I recommend close this issue.

insign avatar Jun 25 '23 19:06 insign

Thanks @insign , closing.

carlosflorencio avatar Jun 25 '23 21:06 carlosflorencio