gitmoji-cli icon indicating copy to clipboard operation
gitmoji-cli copied to clipboard

Published 20 hours ago • verified publisher icon carloscuesta

Using backtick (`) in commit message isn't valid

Open dragid10 opened this issue 2 years ago • 4 comments

Hello @carloscuesta!

Issue: When attempting to use a backtick character (`) like how I would in markdown, gitmoji does not think it is a valid commit

OS: MacOS 12,4 (monterey) gitmoji -v: 5.0.2 Node version: v18.6.0 (Though I did install via homebrew)

Error Message: >> Enter a valid commit message

image

dragid10 avatar Jul 20 '22 13:07 dragid10

Hey! @dragid10

Backticks were removed in https://github.com/carloscuesta/gitmoji-cli/issues/52 as it was possible to inject code between them, I'm wondering if we can reconsider this so we can properly escape the commands instead of "banning" the character

carloscuesta avatar Jul 22 '22 15:07 carloscuesta

Oh wow that actually makes perfect sense, I had no idea of the context. It'd definitely be nice to find some workaround in the future

dragid10 avatar Jul 22 '22 15:07 dragid10

Hey @dragid10 do you want to raise a PR to fix this?

carloscuesta avatar Jul 25 '22 13:07 carloscuesta

Hey @dragid10 do you want to raise a PR to fix this?

I'm more than happy to take a stab at it

dragid10 avatar Jul 25 '22 14:07 dragid10

Hey! I tried to reproduce the injection of commands using backticks in git and looks like I'm not able to reproduce it anymore.

I will remove the guard so backticks can be used as part of the message and title again 🙏🏼

carloscuesta avatar Aug 21 '22 10:08 carloscuesta