i18n_alchemy icon indicating copy to clipboard operation
i18n_alchemy copied to clipboard

Added support for nil date input.

Open saboter opened this issue 4 years ago • 8 comments

Would be nice if the localized assign did not fail on nil date input.

E.g. object.localized({date_col: nil}) throws now:

no implicit conversion of nil into String # /Users/work/.rvm/gems/ruby-2.5.8/gems/i18n_alchemy-0.3.1/lib/i18n_alchemy/date_parser.rb:9:in `_strptime'

saboter avatar May 14 '20 12:05 saboter

Bump

saboter avatar Dec 16 '20 08:12 saboter

Bump

saboter avatar Mar 16 '21 07:03 saboter

@saboter hey hey, apologies for not getting back here... this is on my radar, just haven't had time lately but I'll be taking a look soon. Thanks.

carlosantoniodasilva avatar Mar 24 '21 11:03 carlosantoniodasilva

@carlosantoniodasilva Hello. Good news, thank you.

I have enabled rails 6.1 in my fork in between which most probably broke the CI tests.

saboter avatar Mar 24 '21 11:03 saboter

@saboter right, thanks for that. I'm looking into those right now :+1:

carlosantoniodasilva avatar Mar 24 '21 11:03 carlosantoniodasilva

The fork is deployed in production for couple of days with newest Rails and so far no issues.

saboter avatar Mar 24 '21 11:03 saboter

Bump :).

saboter avatar Mar 21 '23 15:03 saboter

Bump. Works also under Rails 7.1

saboter avatar Jan 18 '24 11:01 saboter