杨朱 · Kiki
杨朱 · Kiki
/remove-lifecycle stale
@neolit123 @pacoxu There are also two problems that need to be resolved. - `"configVersions": null` when print json - print multi JSON documents when it has more than one upgrade...
> print multi JSON documents when it has more than one upgrade possibility. @neolit123 @pacoxu We need a new type. i.e. ```go type XXXXX struct { metav1.TypeMeta AvailableUpgradePlans []UpgradePlan `json:"availableUpgradePlans"`...
Is it possible for Kubeadm to replace all `fmt.Print` with `klog`? If somewhere indeed needs `fmt.Print`, we can keep it. klog flag: ``` commandLine.BoolVar(&logging.skipHeaders, "skip_headers", false, "If true, avoid header...
> the API should be changed to:API 应更改为: > > ```go > // UpgradePlan represents information about upgrade plan for the output > // produced by 'kubeadm upgrade plan' >...
But the `hack/cherry_pick_pull.sh` only accept the PR's number, not support commit. ``` echo "${0} ...: cherry pick one or more onto and leave instructions for proposing pull request" ```
> there should 1 or 2 commits here. > > * 1 if if we move the fix for output to a separate PR > * 2 if the fix...
/hold util https://github.com/kubernetes/kubernetes/pull/123492 is merged.
/cc @pacoxu
test result: ``` root@test-control-plane:/# /kubeadm upgrade plan -ojson { "kind": "UpgradePlan", "apiVersion": "output.kubeadm.k8s.io/v1alpha3", "availableUpgrades": [ { "description": "version in the v1.28 series", "components": [ { "name": "kubelet", "currentVersion": "1 x...