杨朱 · Kiki
杨朱 · Kiki
/cc @RainbowMango @Garrybest
@RainbowMango there are two karmada instance in the same namespace, but only one scheduler estimator service is allowed. becasuse the scheduler and descheduler of two karmada will connected to the...
@RainbowMango > With the proposed prefix, you can let one of the karmada-scheduler connects to like demo1-estimator and another connects to demo2-estimator. Am I right? yes. > I wonder if...
I'll review ASAP.
sorry for too late reply, I will review it tomorrow.
@helen-frank we don't need define the `FactoryForKarmada` func because the factoryImpl has implemented the cmdutil.Factory interface. The root cause is https://github.com/karmada-io/karmada/blob/d9e3bc860629202aa3c8629f743080d61afc2297/pkg/karmadactl/apply.go#L177 we should use UnstructuredClientForMapping instead of ClientForMapping.
/lgtm /cc @lonelyCZ
> Look at my other pr if you have time. I will review it this week.