scikit-hts icon indicating copy to clipboard operation
scikit-hts copied to clipboard

[ENHANCEMENT] Make fitting with exogenous variables more relaible

Open carlomazzaferro opened this issue 4 years ago • 7 comments

Is your proposed enhancement related to a problem? Please describe. Fitting with exogenous variables has no testing of any kind, and is likely broken for some of the models

Describe the solution you'd like Test cases for fitting with exogenous variables for each of the models

Describe alternatives you've considered N/A.

Additional context N/A

carlomazzaferro avatar Mar 30 '20 12:03 carlomazzaferro

I can work on that. For my undergraduate dissertation, I will use M5 data for Walmart sales up to department level (item is too much and involves intermittent demand that is another problem) and I will compare usage of classical models and ML ones with and without exogenous variables.

vtoliveira avatar May 09 '20 16:05 vtoliveira

Any update on this? I was looking for a way to use external regressors in hierarchical Prophet models

rohan-gt avatar Apr 14 '21 18:04 rohan-gt

@rohan-gt I'll try getting to this in the next week or 2

carlomazzaferro avatar Apr 16 '21 07:04 carlomazzaferro

Hey @carlomazzaferro Are there any updates? I am currently working on a problem where having exogenous variables would really help a lot. Are you planning to fix that in the near future? If not, probably I could work on that too and make a PR.

wilfreddesert avatar May 31 '21 07:05 wilfreddesert

Help is definitely wanted. If you want to take a stab, please go ahead. I'm a bit backlogged but very much willing to coordinate with you

As you can tell, my initial timeline got sidetracked. Let me know if you plan on working on this to avoid double work.

@wilfreddesert

carlomazzaferro avatar May 31 '21 13:05 carlomazzaferro

I can provide you with a test case based on Kaggle's store item demand challenge. You can grab the data here. The objective, complete code and results so far can be found in this SO question.

In this example, we only have 4 nodes (2 stores and 2 items) for which I end up with either negative values or off the scale ones.

Downfor-u avatar Aug 31 '21 12:08 Downfor-u

Any updates?

jd12006 avatar Dec 17 '21 10:12 jd12006