Carlos Rodriguez

Results 26 comments of Carlos Rodriguez

In the case of #37267 will still work fine and no need any change after apply this PR

@chmst delete from summary _at least_ this part: "**This PR sets the permission back to core.manage on com_modules.**"

I have tested this item :white_check_mark: successfully on 30936e09f2aed9ce48ce932879e54c3508134371This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43376.

My bad, I totally forgot the "mail sent" notification. The other issue is weird, that worked for me in local. I will do a fresh Joomla install and check from...

@brianteeman Okay you was right, the com_users.ini language loaded was only from the administrator part, as is expected. So adding the follow: ```php // Load com_users site language strings $language...

> Is it perhaps because you are not using the new mail templates? I using it, yes: ```php $mailer = new \Joomla\CMS\Mail\MailTemplate('com_users.registration.user.admin_activated', $app->getLanguage()->getTag()); $mailer->addTemplateData($mailData); $mailer->addRecipient($userMail); ``` > How do the...

from here: https://github.com/joomla/joomla-cms/blob/92c014932228dae7a225184a04b01f0566b336c9/administrator/language/en-GB/com_users.ini#L323

Right, I though you meant the one used in the actions in the administrator. The first 2 strings are used in the users registration Model in the site part https://github.com/joomla/joomla-cms/blob/92c014932228dae7a225184a04b01f0566b336c9/components/com_users/src/Model/RegistrationModel.php#L214...

> When using the new button I expected to get a message saying "the email has been sent" or something like that Done (new string added) > The email that...

> Last changes all look good. One more thing Done. And don't worry, while more corrections the better. Thank you for the help in this.