calendar-bundle Symfony 3 compatibility fixes

Fixes #34

Jul 18 '16 00:07 dmatora

Sorry, it seems it's not backwards-compatible. The build is failing due to a syntax error.

Jul 20 '16 12:07 carlescliment

I'm not aware of symfony3 fork of any bundle, which is symfony2 compatible. That's why i didn't do changes in master branch.

I probably should have changed tests as well, but i just wanted to get functionality working and thought someone else might need it.

On https://github.com/FriendsOfSymfony/FOSMessageBundle/pull/275 so far it took 3 people to get symfony3 up and running, and we don't even know if we are there yet

Jul 21 '16 06:07 dmatora

Okay, what about those suggestions:

First, instead of removing the CSRF protection, we could use form_start and form_end as explained in the official documentation
Second, in order to keep master stable, we could start a new symfony-3 branch and start working on there. That way, users of Symfony2 could still point to master while Symfony3 ones could point to that branch.

What do you think?

Jul 21 '16 09:07 carlescliment

I've created the branch: https://github.com/carlescliment/calendar-bundle/tree/dev-symfony3

Could you please cancel this PR and reopen it towards that branch?

Jul 21 '16 09:07 carlescliment

Yeah, moving to form_start form_end was my initial idea, but after playing with it for a few minutes, i've realized i don't know it deep enough

I can not create pull request of my symfony3 branch, which is 2.5.2 based, into yours, which is master based. And i can not rebase it on master because master doesn't work for me on both symfony2/3 (i've mentioned it on issue #30)

Jul 21 '16 10:07 dmatora

@carlescliment this problem is a show-stopper for the migration to symfony 3.1. Can please you fixit.

Nov 15 '16 09:11 ickbinhier