mpd-tools icon indicating copy to clipboard operation
mpd-tools copied to clipboard

Compile with JDK8 to allow using the library from java 8 projects

Open rabelenda opened this issue 5 years ago • 2 comments

Additionally, upgrade jackson and set FAIL_ON_UNKNOWN_PROPERTIES property to false to avoid getting an exception when an unrecognized property is found in mpd (this is the expected behavior according to the iso, and reflected on schema).

rabelenda avatar Nov 13 '19 12:11 rabelenda

Hi Roger,

Thanks for the PR. Not sure if I want to go back to jdk 8. Why do you want to to this?

Also, you can already configure the objectmapper like this:

MPDParser parser = new MPDParser(MPDParser.defaultObjectMapper()
                .disable(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES));

carlanton avatar Nov 20 '19 20:11 carlanton

Hi, thank you for your reply.

We want to use this great library from a JMeter plugin, and we don't want to add restrictions to users and enforce them to have to install newer jdks. If you don't want to support jdk8 then we would need to maintain a separate fork for this :-(.

Regarding modifying the object mapper from client code, do you think is better doing that from client side? I mean, it seems that the standard specifies that any "unknown" xml attribute or element should be ignored, so I would expect the library to do that by default.

Regards

rabelenda avatar Nov 21 '19 13:11 rabelenda