Neil
Neil
> I do worry that people could easily create multiple filters that do the same thing with different names if its not easy/obvious to look at what they do and...
Hi all, I'm ready to put this into code review. Cheers!
> Selecting Filter → Saved, then clicking “Apply” causes a “saved (nothing)” filter token to be added which doesn’t seem to be correct This is duplicating existing process. For instance...
> I just wanted to showcase what I saw this morning so it doesn't get forgotten. Yes, I saw your first note... I'm aware of the issue. Same thing happens...
Yea I'm not set on the filters page, thought it might be useful. I'm having trouble visualizing the ask. Can you share a mockup?
> * remove the “edit filter” modal since the filter can be edited inline, and then saved if desired This makes me sad as I spent a lot of time...
I've commited an update. Removes the page and the sidebar item and the need for the modal. The buttons are all dead right now as I'd like to get the...
It's no grief, all part of the process. I'm enjoying it. Cheers!
> This is very good feedback, and I’m sorry you had to rip out code you spent time on. No worries at all, I should be able to use the...
Hey all, I have everything working as intended. Please don't spend any time with a code review just yet as I still need to clean up files from my previous...