redefine-custom-elements icon indicating copy to clipboard operation
redefine-custom-elements copied to clipboard

Use a single definition per tag name

Open rictic opened this issue 3 years ago • 2 comments

Update it when the tag is redefined.

This way LatestCtor and the callbacks are updated for all instances immediately on redefinition.

I'm not certain this change is an improvement in all cases, but it's the behavior that I think we generally want when doing HMR in google, but I could see the value in making it an option.

rictic avatar Sep 15 '22 01:09 rictic

@rictic thanks for the PR, but it is impossible to review... can you update the PR with the actual changes? The diff, even when ignoring the whitespaces, it is the entire file.

caridy avatar Nov 30 '22 03:11 caridy

This builds on top of https://github.com/caridy/redefine-custom-elements/pull/3 to make it easier to merge them both, if you look at just the second and third commits the change is clearer

rictic avatar Nov 30 '22 20:11 rictic