Caridy Patiño comments

Results 457 comments of


                                            Caridy Patiño

Add skip element to hook object AND allow root DOM with children in patch

It is hard to tell because I haven't understand what are you trying to do. Those changes are definitely not something that we can do because it will impact the...

Support planting external DOM nodes in VNode tree

If you just want a cut in the fiber of rendering, where you can add your own DOM elements without the diffing algo taking over the subtree, you can do...

`VNodeData` property is mandatory

I'm supportive of this considering that in all my projects, I do enforce this rule on top of the snabbdom, and pushing it down to snabbdom seems like a good...

`VNodeData` property is mandatory

/cc @diervo @pmdartus

Hook signature of create

Can you elaborate more? Creating an element while diffing two vnodes (the old one and the new one) is an important step in the process, and I don't think it...

`h` should be more strict about children

> `h("li", {}, () => "c"),` > `h("li", {}, [() => "c"]),` the second one "sort-of" work because of the nature of JS in which the function passed as the...

Document that using `patch` with text nodes is unsupported

yeah, this is a very edge case that we should probably not attempt to fix, but maybe we should add a note somewhere in the README or something to make...

Using innerHTML prop to patch non-empty node results in TypeError (null)

Ok. Here is the explanation: * container is in the DOM, and has child elements attached to it (whatever is in the DOM). * toVNode(container) returns a vnode that not...

Using innerHTML prop to patch non-empty node results in TypeError (null)

I don't think it destroys it, snabbdom patching mechanism is very resilient. My main concern is that by allowing innerHTML as a prop against a vnode that has children, the...

Using innerHTML prop to patch non-empty node results in TypeError (null)

It turns out that I ran into this exact problem when trying to implement a recovery mechanism (similar to react's error boundaries), where a child vnode throws an error during...