cargo-binstall icon indicating copy to clipboard operation
cargo-binstall copied to clipboard

Published 20 hours ago • verified publisher icon cargo-bins

When [email protected] releases: upgrade and stop using patched ring 0.16 for windows ARM release builds

Open passcod opened this issue 2 years ago • 8 comments

See:

  • https://github.com/briansmith/ring/issues/1514
  • https://github.com/briansmith/ring/issues/1167

We currently use a patched ring 0.16 for release builds on Windows ARM. It seems the underlying issue will be resolved with ring 0.17, so we should stop doing that then.

passcod avatar Jan 08 '23 03:01 passcod

ring is planning on a 0.16.21 release which will also fix the build for aarch64-pc-windows-msvc https://github.com/briansmith/ring/issues/1551

NobodyXu avatar Jan 09 '23 10:01 NobodyXu

I think we did this already?

passcod avatar Jun 24 '23 02:06 passcod

I think we did this already?

We are still using v0.16.20 https://github.com/cargo-bins/cargo-binstall/blob/ca00cbaccc0fd5f6b07babce2af5507b18390c2a/Cargo.lock#L2812

NobodyXu avatar Jun 24 '23 03:06 NobodyXu

I think the upstream hasn't released v0.16.21

NobodyXu avatar Jun 24 '23 03:06 NobodyXu

ugh ffs

passcod avatar Jun 24 '23 14:06 passcod

With ring v0.17.5 and rustls v0.21.8 released, it's time to move on.

sigoden avatar Oct 26 '23 14:10 sigoden

There will be an automatic dependencies upgrade today, if that removes the old ring then I will open a PR to remove the patch and possibly cut a new patch release.

NobodyXu avatar Oct 26 '23 21:10 NobodyXu

#1474 bumps the dep, but it turns out that hickory-dns still uses ring v0.16, so have to wait for them to bump their ring again

NobodyXu avatar Oct 27 '23 03:10 NobodyXu

Fixed in #1869

NobodyXu avatar Aug 10 '24 08:08 NobodyXu