cargo-binstall icon indicating copy to clipboard operation
cargo-binstall copied to clipboard

Support installing libs and includes?

Open NobodyXu opened this issue 3 years ago • 4 comments

https://github.com/wasmerio/wasmer/issues/3106

wasmer pre-built tarballs include not only bins, but also libs and includes necessary for wasmer create-exe. Perhaps we can add new manifest configurations libs = true and includes = true which will install them to .cargo if present?

NobodyXu avatar Sep 07 '22 08:09 NobodyXu

That feels very much like building an entire feature just for a single package, and is strongly departing from the .cargo usage. Additionally, on Windows, it's my understanding that DLLs placed next to a binary will get loaded by that binary (it's how a lot of game piracy works), so we can't just dump them in a folder or something.

passcod avatar Sep 07 '22 09:09 passcod

That feels very much like building an entire feature just for a single package, and is strongly departing from the .cargo usage.

Well, that feature is indeed only used by wasmer currently, but perhaps it might also be used by other softwares?

Additionally, on Windows, it's my understanding that DLLs placed next to a binary will get loaded by that binary (it's how a lot of game piracy works), so we can't just dump them in a folder or something.

Ahhh, sounds like a lot complex than I think.

I'm not sure whether my proposed solution is the right one to do, but I'd like @passcod your advice. Alternatives would be wasmer downloading the includes/ and libs/ themselves.

NobodyXu avatar Sep 07 '22 09:09 NobodyXu

I think let's park this for now until we have some other project that wants it, and that could help inform the approach to take, or we're ready to really progress on WASI.

It's the more boring path, but I think the priority is getting to 1.0, getting to a stable, secure place that can then serve as the launchpad for all this more ambitious stuff.

passcod avatar Sep 07 '22 10:09 passcod

@passcod Agreed

NobodyXu avatar Sep 07 '22 10:09 NobodyXu