portfolio
portfolio copied to clipboard
portfolio currency tab selection should be serialized as query param
portfolio currency tab selection should be serialized as query param, and when you navigate to an asset from the currency tab, and then navigate back to the portfolio card, you should still see the currency tab.
In this case we should create a cardstack route specifically for the portfolio card that uses a query param. Its important to use cardstack routing in order for the animations to work correctly. similar to how we are dealing with the selected currency on the asset card: https://github.com/cardstack/portfolio/blob/master/cards/asset/cardstack/static-model.js#L8-L10 and https://github.com/cardstack/portfolio/blob/master/packages/common/addon/mixins/currency-params.js
Is this what https://github.com/cardstack/portfolio/commit/c96803cf43e84c02ebf8c9c0ecbc3474abbbe548 was supposed to do or start?
The currency
query param is not serialized (doesn't appear in the URL) on the asset card yet, but the commit seems to have been made for this reason.
I think @bagby started the work, but was unable to get it done in time for the demo that we had to ING. so it still needs to be completed.