ReduxMovieDB icon indicating copy to clipboard operation
ReduxMovieDB copied to clipboard

Favorites issue #18

Open ftp27 opened this issue 4 years ago β€’ 5 comments

ftp27 avatar Oct 06 '19 23:10 ftp27

Codecov Report

Merging #34 into master will increase coverage by 0.67%. The diff coverage is 73.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
+ Coverage    70.2%   70.88%   +0.67%     
==========================================
  Files          13       15       +2     
  Lines         443      522      +79     
==========================================
+ Hits          311      370      +59     
- Misses        132      152      +20
Impacted Files Coverage Ξ”
...ovieDB/Controllers/MovieDetailViewController.swift 0% <0%> (ΓΈ) :arrow_up:
ReduxMovieDB/Extensions/Boolean.swift 0% <0%> (ΓΈ)
ReduxMovieDB/ViewState/MovieDetailViewState.swift 100% <100%> (ΓΈ) :arrow_up:
...uxMovieDB/Extensions/UIImageView+MoviePoster.swift 96.72% <100%> (ΓΈ) :arrow_up:
...xMovieDB/Controllers/MovieListViewController.swift 87.03% <69.23%> (-2.55%) :arrow_down:
ReduxMovieDB/State/MainState.swift 97.05% <88.23%> (-2.95%) :arrow_down:
ReduxMovieDB/Storages/FavoritesStorage.swift 97.29% <97.29%> (ΓΈ)

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update f57d4cb...fe60b93. Read the comment docs.

codecov-io avatar Oct 06 '19 23:10 codecov-io

Hi @ftp27 ! Thanks again for your contribution! I'll review as soon as possible.

cardoso avatar Oct 07 '19 13:10 cardoso

It looks better now πŸ™‚

ftp27 avatar Oct 17 '19 21:10 ftp27

@ftp27 thank you! I'll review again as soon as possible

cardoso avatar Oct 18 '19 17:10 cardoso