developer-portal icon indicating copy to clipboard operation
developer-portal copied to clipboard

Published 20 hours ago • verified publisher icon cardano-foundation

CIP relative links: build script fails when not anchored in current directory

Open rphair opened this issue 2 years ago • 5 comments

Happening now that https://github.com/cardano-foundation/CIPs/pull/242 is merged (yesterday) into their master branch and will affect all builds from our staging branch until a fix is merged. Most notably affecting https://github.com/cardano-foundation/developer-portal/pull/1005 and will affect anything else built via the CI more recently. I'll submit a fix for this upstream and report back here.

rphair avatar Aug 02 '23 12:08 rphair

Will be fixed upstream when https://github.com/cardano-foundation/CIPs/pull/574 is merged.

rphair avatar Aug 02 '23 14:08 rphair

Thank you @rphair for bringing this also to the developer portal. As written in the other issue, the portal must not rely on it, and the script must not be so fragile.

katomm avatar Aug 02 '23 14:08 katomm

@rphair I have yet to test through all the possible cases, but from what I can see, #1122 should fix or significantly improve the problem.

katomm avatar Aug 02 '23 17:08 katomm

OK, since this has been reopened for the more general case I'm retitling it accordingly 🤓

rphair avatar Aug 02 '23 18:08 rphair

@katomm @fill-the-fill cross-referencing #1229.

rphair avatar Mar 20 '24 16:03 rphair

This has been getting some visibility with the newer #1262 and I've been watching for CIP related build failures for a while, I believe this issue indeed has been fixed by #1122. cc @fill-the-fill @katomm

rphair avatar Jun 02 '24 10:06 rphair