guild-operators icon indicating copy to clipboard operation
guild-operators copied to clipboard

syntactic bug in entrypoint.sh

Open Fuma419 opened this issue 10 months ago • 0 comments

Describe the bug Redirect the output of the sed command back into the script file itself using >>. This can lead to unintended consequences like duplicating or corrupting the file because sed -i modifies the file in place, and the >> operator appends the output of the command to the end of the file.

I did not find any functional issues. Resolving this would improve robustness though.

To Reproduce Steps to reproduce the behavior:

https://github.com/cardano-community/guild-operators/blob/5e17fc32705d84ae4529a6ea55b181f028ab9973/files/docker/node/addons/entrypoint.sh#L40

Expected behavior silence the output with '/dev/null 2>&1'

Screenshots If applicable, add screenshots to help explain your problem. Screenshot 2024-04-14 at 11 58 06 PM

Version:

  • OS: Ubuntu 22
  • Product version: latest release
  • Cardano Node version: 8.7.1
  • Network you're connecting to:mainnet

Additional context Add any other context about the problem here.

Fuma419 avatar Apr 15 '24 04:04 Fuma419