card.io-iOS-SDK icon indicating copy to clipboard operation
card.io-iOS-SDK copied to clipboard

Unable to localize strings

Open mbaylet opened this issue 9 years ago • 7 comments

Hi,

I'm struggling with the localization of the SDK. All text is localized based on the user's phone language wich is fine. The problem is if i want to localize the text of the localization file i can't, is there a way to do it ? If i look in the source we can find the files in assets/strings/ Is it possible to include the strings files in the sdk, so anyone can adjust it based on their needs. Thanks

mbaylet avatar Feb 01 '16 10:02 mbaylet

The only way to do that right now is to modify the strings and build the library from source. This could be a future enhancement to make it easier but I think how the library is distributed and integrated would have to be re-thought a bit.

bluk avatar Feb 12 '16 16:02 bluk

I have the same issue. I support languages which are not supported by the framework at the moment. Would be nice to have some injection of the string possible

Japspre avatar Jul 27 '16 10:07 Japspre

I just saw the scanOverlayView property. If set with UILabel with localizedString, will it overwrite the current label with string?

Japspre avatar Jul 27 '16 10:07 Japspre

Seem like this issue was already solved but this hasnt been updated since: https://github.com/card-io/card.io-iOS-SDK/blob/11d9e7126401f07ef529ddefa24c7f3aa739cf4e/CardIO/CardIOView.h#L59

Japspre avatar Jul 27 '16 15:07 Japspre

@Japspre, that extra refers to just one string, the scan instructions. We don't offer a mechanism for replacing all strings with your own translation.

braebot avatar Jul 28 '16 16:07 braebot

@braebot you are right, but in my particular case, I only need to localise the scan instructions, so that property fixes my problem.

Japspre avatar Jul 29 '16 10:07 Japspre

@braebot Hi,could you give some property to change placeholder,e.g."MM / YY" -> "Month / Year",thank you.

Goodman333 avatar Nov 23 '16 12:11 Goodman333