card.io-iOS-SDK icon indicating copy to clipboard operation
card.io-iOS-SDK copied to clipboard

SampleApp: Preview cardImage and support iPhone 6/6+

Open cybertk opened this issue 10 years ago • 4 comments

cybertk avatar Jul 12 '15 07:07 cybertk

@cybertk in general we'd like to keep our SampleApp very simple.

Could you please explain your reasons for suggesting these changes?

dgoldman-pdx avatar Jul 12 '15 22:07 dgoldman-pdx

The reasons are

  • Current SampleApp does not support iPhone 6/6+. It displayed ugly on those newer devices.
  • CardIO has CreditCardInfo.cardImage support, and I cannot preview this feature when I run pod try or start the Demo app from Xcode.

cybertk avatar Jul 13 '15 05:07 cybertk

I'm definitely in favor of supporting the iPhone 6/6+. Thanks for doing that.

The cardImage feature is much less commonly used. I think I'm with @dgoldman-ebay on this one: I'd rather keep the sample app extremely simple.

Does your first commit (enabling iPhone 6/6+) work correctly if applied without the second commit?

josharian avatar Jul 24 '15 16:07 josharian

I second @josharian

hkareemllc avatar Dec 29 '15 21:12 hkareemllc