carbon-lang icon indicating copy to clipboard operation
carbon-lang copied to clipboard

Remove clangd BUILD patch

Open jonmeow opened this issue 2 years ago • 5 comments

#3112 patched the LLVM build to expose files from clangd, here. If possible, this should be upstreamed: we should be trying to stay as close to LLVM upstream as we can, avoiding patches which we would need to maintain.

If it can't be upstreamed because upstream doesn't want these files used as a library, the dependency should be re-evaluated. In general we don't want to add dependencies on internal libraries, because of a lack of long-term stability guarantees.

FYI @josh11b @Maan2003

jonmeow avatar Aug 22 '23 20:08 jonmeow

We triage inactive PRs and issues in order to make it easier to find active work. If this issue should remain active or becomes active again, please comment or remove the inactive label. The long term label can also be added for issues which are expected to take time.

This issue is labeled inactive because the last activity was over 90 days ago.

github-actions[bot] avatar Nov 21 '23 01:11 github-actions[bot]

@josh11b Is this something that you can investigate? (I'm concerned about what happens if there's an API change, or the patch breaks)

jonmeow avatar Nov 21 '23 17:11 jonmeow

Got https://github.com/llvm/llvm-project/pull/81556 accepted upstream. Next time we sync llvm, we can hopefully remove (most of?) the patch (though the library did get renamed in the process).

josh11b avatar Mar 20 '24 20:03 josh11b

Would you like to take care of syncing?

jonmeow avatar Mar 20 '24 21:03 jonmeow

next time we sync llvm ,

archanakush900 avatar Mar 24 '24 15:03 archanakush900