carbon-lang
carbon-lang copied to clipboard
carbon-language
Unused Pattern Bindings (Unused Function Parameters)
This proposal specifies how unused pattern bindings are written in the Carbon programming language. This is a more general problem statement of "how do users specify unused function parameters" as function parameter declarations are a more specific form of pattern
Related issue #1996
I framed this around patterns more generally based on the discussion in #476. If this should only talk about function parameters, let me know and I'll adjust the wording
Sorry for the delay in updating this. I've pushed some small changes that cover the areas you suggested -- they're very high level, let me know if I need to go in to more detail on context or the why behind them and I can spend a bit more time with it.
I see this had been missing proposal labels -- I've added those to help make sure it's getting reviewed as such (leads have been busy but I think there'll be increased availability now)
Looks good to me, noting outstanding comments.
Just a tip regarding force-pushes though -- those can break GitHub's comment associations, and it makes it harder to determine what's changed since the last review (with regular pushes, GitHub can show a delta). We're going to squash-and-merge PRs anyways, so if you use regular pushes the end result will actually be the same and it can make it easier to review. :)
Looks good to me, noting outstanding comments.
Just a tip regarding force-pushes though -- those can break GitHub's comment associations, and it makes it harder to determine what's changed since the last review (with regular pushes, GitHub can show a delta). We're going to squash-and-merge PRs anyways, so if you use regular pushes the end result will actually be the same and it can make it easier to review. :)
Whoops sorry about that -- will adjust going forward