carbon-lang icon indicating copy to clipboard operation
carbon-lang copied to clipboard

Published 20 hours ago • verified publisher icon carbon-language

Reflect "Comments #198" in the design docs

Open josh11b opened this issue 3 years ago • 4 comments

Proposal #198 was accepted but https://github.com/carbon-language/carbon-lang/tree/trunk/docs/design/lexical_conventions/README.md still says "TODO: ... comments", and that should be linked from https://github.com/carbon-language/carbon-lang/blob/trunk/docs/design/README.md#code-and-comments . Since the design decision in #198 is somewhat surprising, it would be good to explain it and possibly the alternatives considered somewhere in the lexical_conventions directory.

josh11b avatar Aug 11 '22 21:08 josh11b

Hello @josh11b, I would like to work on this issue.

avinal avatar Aug 12 '22 19:08 avinal

Hello @josh11b, I would like to work on this issue.

Sounds good! You'll want to make sure you sign up for contributor access, see https://github.com/carbon-language/carbon-lang/blob/trunk/CONTRIBUTING.md#collaboration-systems .

josh11b avatar Aug 12 '22 20:08 josh11b

I have requested contributor access. In the meantime, I am going through the discussions.

avinal avatar Aug 13 '22 18:08 avinal

FYI: creating PRs doesn't require contributor access (see the last paragraph of getting access for an explanation of what access is appropriate when)

jonmeow avatar Aug 15 '22 16:08 jonmeow

We triage inactive PRs and issues in order to make it easier to find active work. If this issue should remain active or becomes active again, please comment or remove the inactive label. The long term label can also be added for issues which are expected to take time. This issue is labeled inactive because the last activity was over 90 days ago.

github-actions[bot] avatar Nov 14 '22 02:11 github-actions[bot]

Will add by this weekend.

avinal avatar Nov 14 '22 12:11 avinal

Is there any additional help needed on this issue? I can dedicate time next week to help. I can check in on this issue in Discord Monday morning.

eeshvardasikcm avatar Dec 15 '22 22:12 eeshvardasikcm

Is there any additional help needed on this issue? I can dedicate time next week to help. I can check in on this issue in Discord Monday morning.

@eeshvardasikcm , it looks like @avinal created #2064 but did not finish it. I am not aware of anyone else working on this.

josh11b avatar Dec 16 '22 00:12 josh11b

Hey @josh11b @eeshvardasikcm, apologies for not being able to complete this till now, last few months were very busy. I don't have access to a system till 20th Dec, as soon I get back, I will push my changes. Also no additional help is required AFIR, if something comes up I will ping you. Thanks for your understanding.

avinal avatar Dec 16 '22 06:12 avinal

...I will push my changes. Also no additional help is required...

Okay. There's a different issue that I can do. Thanks for the update. josh11b is monitoring this issue.

eeshvardasikcm avatar Dec 16 '22 23:12 eeshvardasikcm

@avinal @josh11b Can I try it...?

aswin2108 avatar Feb 26 '23 08:02 aswin2108

Can you please explain in detail what do I have to do? @josh11b and then assign me this issue

amyra98 avatar Feb 28 '23 12:02 amyra98

@amyra98 Actually I am working on this and will create a pr shortly!

aswin2108 avatar Feb 28 '23 13:02 aswin2108

I want to work on this Issue please assign me.

KAWALMEET-SINGH avatar Mar 09 '23 14:03 KAWALMEET-SINGH

@KAWALMEET-SINGH We typically won't assign issues. I've added some documentation for why. Please feel to work on it if you have time [a "good first issue" can help familiarize with the project], but please note aswin2108 recently sent out #2641.

jonmeow avatar Mar 10 '23 17:03 jonmeow

Yeah, actually I was waiting for the review to happen! I was said that it was in the queue.

aswin2108 avatar Mar 10 '23 17:03 aswin2108