carbon-design-system
fix(API Key Modal): heading,label and downloadlink
Closes #6250 and #6251
Fixed the heading text and added aria-label and role of for APIKeyDownloader
What did you change? packages/ibm-products/src/components/APIKeyModal/APIKeyDownloader.js
packages/ibm-products/src/components/APIKeyModal/APIKeyModal.tsx packages/ibm-products/src/components/APIKeyModal/APIKeyModal.stories.jsx
How did you test and verify your work? voiceover
Deploy Preview for carbon-for-ibm-products ready!
| Name | Link |
|---|---|
| Latest commit | 9206cacb73a9c431ccabcd5835f920bdbc9801db |
| Latest deploy log | https://app.netlify.com/sites/carbon-for-ibm-products/deploys/6724e332b6315e0009a50346 |
| Deploy Preview | https://deploy-preview-6298--carbon-for-ibm-products.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
Deploy Preview for ibm-products-web-components ready!
| Name | Link |
|---|---|
| Latest commit | 9206cacb73a9c431ccabcd5835f920bdbc9801db |
| Latest deploy log | https://app.netlify.com/sites/ibm-products-web-components/deploys/6724e332ae0a670007f442d4 |
| Deploy Preview | https://deploy-preview-6298--ibm-products-web-components.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 79.36%. Comparing base (
dcecd22) to head (9206cac). Report is 1 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #6298 +/- ##
==========================================
+ Coverage 79.34% 79.36% +0.01%
==========================================
Files 395 395
Lines 12880 12882 +2
Branches 4256 4258 +2
==========================================
+ Hits 10220 10224 +4
+ Misses 2660 2658 -2
| Components | Coverage Ξ | |
|---|---|---|
| ibm-products | β
<ΓΈ> (β
) |
|
| ibm-products-web-components | β
<ΓΈ> (β
) |
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
prop name can be changed to camelCase
yea it should be, its added by mistake. Thanks @devadula-nandan for reviewing!
Hi @anamikaanu96 , all good except one last thing which is confusing.
The issue #6251 states that headings should be organized hierarchically. also, it indicates the use of H1, while I observe two H2 headings that do not follow this hierarchical structure.
should it be H2 H3 ?
edit: oh wait, they are coming from ModalHeader which is not in our control.
<ModalHeader
title={title} // shows a h2
label={modalLabel} // shows a h2
/>
do we need to raise an issue for carbon react? im guessing there is an active issue for this
