ibm-products
ibm-products copied to clipboard
refactor(Coachmark): implement popover and floating ui
Closes #5356
first draft of converting Coachmark to use popover and implement floating-ui bugs to rectify
- ~focus not going to the button inside the popover when its opened~
- ~floating (a more appropriate name could be draggable) variant is not working~
- layout shift occurs when opening the popover, or clicking any buttons inside it. (looks like this is already present before, and can be noticeable if the coachmark parent overflowing)
- ~tests and avt~
What did you change?
packages/ibm-products-styles/src/components/Coachmark/_coachmark-overlay.scss packages/ibm-products-styles/src/components/CoachmarkBeacon/_coachmark-beacon.scss packages/ibm-products/src/components/Coachmark/Coachmark.tsx packages/ibm-products/src/components/Coachmark/CoachmarkOverlay.tsx
How did you test and verify your work?
storybook
Deploy Preview for carbon-for-ibm-products ready!
| Name | Link |
|---|---|
| Latest commit | bc63866b309eb5c616bd54b5babe424072ca3704 |
| Latest deploy log | https://app.netlify.com/sites/carbon-for-ibm-products/deploys/6697ac7ded7adc0008da5618 |
| Deploy Preview | https://deploy-preview-5574--carbon-for-ibm-products.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.