ibm-products icon indicating copy to clipboard operation
ibm-products copied to clipboard

Published 20 hours ago • verified publisher icon carbon-design-system

UserAvatar: Design review

Open matthewgallo opened this issue 1 year ago • 2 comments

This issue is to be completed by the community contributor for User Avatar Marion Hekeler (@marion-bruells) @cate-wilcox

Design review guidelines

Standards

  • [ ] All pattern updates/changes/iterations have been discussed with the component developer
  • [ ] Patterns have been approved by either DSAG or another approving entity

Pattern and behavior

  • [ ] The component behaves according to the guidelines set by the component maintainer
  • [ ] The component’s UI matches the pattern specifications set by the pattern maintainer
  • [ ] The component’s motion matches the specifications set by the pattern maintainer(s)
  • [ ] The UI produced is responsive, cross-browser, and responds to the currently set Carbon theme.
  • [ ] Colors, themes, sizes and additional props are true and correct, aligning with Carbon set tokens (unless otherwise specified by the pattern)
  • [ ] Paddings/margins/spacings are true and correct, in both desktop and mobile views

Storybook

  • [ ] A functioning component renders in Storybook
  • [ ] The Storybook displays multiple scenarios that show how the component can be used
  • [ ] Changing props in the Storybook updates the component

Final review by product PAL maintainer

  • [ ] Check off this list
  • [ ] Let Product PAL maintainers know when you are ready for a review in this issue

matthewgallo avatar Jun 19 '24 14:06 matthewgallo

@matthewgallo Could we get a link to the PR? Thanks

aubrey-oneal avatar Jun 27 '24 14:06 aubrey-oneal

This review would be to review the component as it exists currently in our storybook. That way we can move it from canary to released.

matthewgallo avatar Jun 27 '24 15:06 matthewgallo

@marion-bruells @cate-wilcox Would you be able to perform a design review on the UserAvatar? We usually would use a spec. I think the closest we have now are #4017 and #4016. If either of you has the original Sketch files, that would be a help too since some of the images in the website might need updating.

https://pages.github.ibm.com/carbon/ibm-products/components/user-avatar/usage/#accessibility Noticed that these are using hexcodes rather than text tokens.

elycheea avatar Oct 03 '24 19:10 elycheea

@elycheea I did an update on this really long time ago, but I think the PR never got merged and lost. https://github.ibm.com/CDAI-design/pal/pull/1600 Overall it looks good to me with all the changes on the site and I also reviewed the coded component.

The only change I suggest on the site (like you mentioned): change hex codes from #00000 and #FFFFFF to $text-primary considering the light/dark theme.

I am sure I have somewhere an old sketch file with the images. I’ll try to find it :)

marion-bruells avatar Oct 07 '24 08:10 marion-bruells

Thanks so much @marion-bruells! I actually brought your PR over to the new site already, but didn’t realize you checked the code too. :D

elycheea avatar Oct 07 '24 13:10 elycheea