ibm-products icon indicating copy to clipboard operation
ibm-products copied to clipboard

Accessibility in Tearsheet doesnt't work, focus jump out of the tearsheet

Open RadekKpc opened this issue 2 years ago • 1 comments

After changing @carbon/ibm-cloud-cognitive version from: "@carbon/ibm-cloud-cognitive": "^1.34.0", "carbon-components": "10.52.0", "carbon-components-react": "7.52.0", to: "@carbon/ibm-cloud-cognitive": "^1.11.2", "carbon-components": "10.58.3", "carbon-components-react": "7.59.3",

Accessibility in Tearsheet stoped working, After clicking tab several times, when focus is at the last item it doesn't jump to the beginning of thearsheet or closing cross button, but jumps out of the tearsheet.

RadekKpc avatar Oct 14 '22 15:10 RadekKpc

It jumps to following button, but it should back to "x" button: image

RadekKpc avatar Oct 20 '22 13:10 RadekKpc

Can you check your versions again? If this is working in the most recent versions, we recommend using those.

elycheea avatar Oct 27 '22 17:10 elycheea

@elycheea Sorry, we moved from: "@carbon/ibm-cloud-cognitive": "1.11.2", "carbon-components": "10.52.0", "carbon-components-react": "7.52.0",

to: "@carbon/ibm-cloud-cognitive": "^1.34.0", "carbon-components": "10.58.3", "carbon-components-react": "7.59.3",

Could you check if it works on 1.34.0? I can see in a storybook that it still not works on 1.35.0 which is the newest version. https://carbon-for-ibm-products.netlify.app/?path=/story/ibm-products-components-tearsheet-tearsheet--tearsheet

RadekKpc avatar Oct 31 '22 08:10 RadekKpc

@elycheea Is there a way for us to see an older version of storybook? As RadekKpc said it doesn't work with the latest storybook (at 1.35.1).

obambrough avatar Nov 10 '22 16:11 obambrough

@elycheea Could you please look at @obambrough comment?

RadekKpc avatar Dec 05 '22 10:12 RadekKpc

@obambrough If there is no storybook of the previous version you probably need to checkout your main branch to this commit and build storybook locally. That should allow you to investigate the issue.

RadekKpc avatar Dec 05 '22 10:12 RadekKpc

Any updates on this?

fbarroso24 avatar Oct 13 '23 19:10 fbarroso24

We're also facing this issue while reducing accessibility issues in our product. This is an essential improvement for being compliant. Are you planning to fix this soon? @elycheea

miriam-g avatar Oct 18 '23 06:10 miriam-g

Focus trap was addressed in #3499 so should be available from 2.26.0 and 1.71.0.

There is a follow on issue we are tracking in #5590.

elycheea avatar Jul 16 '24 15:07 elycheea