ibm-products icon indicating copy to clipboard operation
ibm-products copied to clipboard

inline edit refactor design review

Open davidmenendez opened this issue 2 years ago • 1 comments

Design review

for inline edit refactor (V2)

Standards

  • [ ] All pattern updates/changes/iterations have been discussed with the component developer
  • [ ] Patterns have been approved by either DSAG or another approving entity

Pattern and behavior

  • [ ] The component behaves according to the guidelines set by the pattern maintainer
  • [ ] The component’s UI matches the pattern specifications set by the pattern maintainer
  • [ ] The component’s motion matches the specifications set by the pattern maintainer(s)
  • [ ] The UI produced is responsive, cross-browser, and responds to the currently set Carbon theme.
  • [ ] Colors, themes, sizes and additional props are true and correct, aligning with Carbon set tokens (unless otherwise specified by the pattern)
  • [ ] Paddings/margins/spacings are true and correct, in both desktop and mobile views

Storybook

  • [ ] A functioning component renders in Storybook
  • [ ] The Storybook displays multiple scenarios that show how the component can be used
  • [ ] Changing props in the Storybook updates the component

davidmenendez avatar Oct 06 '22 14:10 davidmenendez

@davidmenendez When clicking into the text field, once I make a change, the text field width should not change. The Save icon button should appear, but it shouldn't need to adjust the field width.

sdignum avatar Oct 20 '22 20:10 sdignum

Looks good to me @davidmenendez. Let me know if you need for me to do anything else

sdignum avatar Oct 24 '22 20:10 sdignum