ibm-products icon indicating copy to clipboard operation
ibm-products copied to clipboard

chore: update pre-commit hook

Open davidmenendez opened this issue 2 years ago • 1 comments

i noticed the formatter in the pre-commit hook wasn't working, so i wanted to do some investigating into it.

it seems to me like we probably have way too much bloat in our main package file. the lint-staged commands seemed a little redundant or unnecessary. like, i don't know why we need the --check flag (https://prettier.io/docs/en/cli.html#--check) to tell the user to run format when it should just be formatting for you. admittedly, i'm not an expert, but i did some research and this is what i came up with. i think making more adjustments to package by cleaning it up and streamlining it would be good for us in the long run.

would love to talk more about this topic.

davidmenendez avatar Aug 31 '22 21:08 davidmenendez

Deploy Preview for carbon-for-ibm-products ready!

Name Link
Latest commit 250a2664cec540d4fa776c60c658d50e1b13aa7c
Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/632b6489af53b0000966ec19
Deploy Preview https://deploy-preview-2248--carbon-for-ibm-products.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Aug 31 '22 21:08 netlify[bot]

tagging @lee-chase if you can give any insight on this topic it would be greatly appreciated

davidmenendez avatar Sep 02 '22 15:09 davidmenendez