ibm-products icon indicating copy to clipboard operation
ibm-products copied to clipboard

chore(Datagrid): allow label text values to be passed in to Datagrid

Open matthewgallo opened this issue 3 years ago • 2 comments

Contributes to #1782

This PR allows the Datagrid to accept certain label text items in order to support translation. We might want to wait until @kai-liu's PRs are updated/reviewed/merged before looking at this one to avoid any conflicts.

What did you change?

packages/cloud-cognitive/src/components/Datagrid/Datagrid.stories.js
packages/cloud-cognitive/src/components/Datagrid/Datagrid/addons/CustomizeColumns/Actions.js
packages/cloud-cognitive/src/components/Datagrid/Datagrid/addons/CustomizeColumns/Columns.js
packages/cloud-cognitive/src/components/Datagrid/Datagrid/addons/CustomizeColumns/CustomizeColumnsModal.js
packages/cloud-cognitive/src/components/Datagrid/Datagrid/addons/CustomizeColumns/ModalWrapper.js
packages/cloud-cognitive/src/components/Datagrid/Datagrid/addons/RowSize/RowSizeDropdown.js
packages/cloud-cognitive/src/components/Datagrid/Datagrid/addons/RowSize/RowSizeRadioGroup.js
packages/cloud-cognitive/src/components/Datagrid/useCustomizeColumns.js
packages/cloud-cognitive/src/components/Datagrid/useDisableSelectRows.js
packages/cloud-cognitive/src/components/Datagrid/useRowSize.js

How did you test and verify your work?

I was able to add the labels as part of the useDatagrid hook in the stories, I left the default values for these items so in case they are not passed, the component still renders as expected.

matthewgallo avatar Aug 09 '22 19:08 matthewgallo

Deploy Preview for carbon-for-ibm-products ready!

Name Link
Latest commit c215dccd5aa8681670ae446bde03391f30b22afa
Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/6310da13ba0a7200085bac80
Deploy Preview https://deploy-preview-2161--carbon-for-ibm-products.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Aug 09 '22 19:08 netlify[bot]

Waiting to merge after #2178

elycheea avatar Aug 16 '22 15:08 elycheea