carbon icon indicating copy to clipboard operation
carbon copied to clipboard

refactor: rewrite defaultFilterItems in typescript and add tests

Open adamalston opened this issue 5 months ago • 3 comments
trafficstars

No issue.

Rewrote defaultFilterItems in TypeScript and added tests.

Changelog

New

  • Added defaultFilterItems tests.

Changed

  • Rewrote defaultFilterItems in TypeScript.
  • Pulled the input normalization out of the loop for performance.

Testing / Reviewing

I left a TODO with a question.

yarn test packages/react

PR Checklist

As the author of this PR, before marking ready for review, confirm you:

  • [x] Reviewed every line of the diff
  • [x] Updated documentation and storybook examples
  • [x] Wrote passing tests that cover this change
  • [x] Addressed any impact on accessibility (a11y)
  • [x] Tested for cross-browser consistency
  • [x] Validated that this code is ready for review and status checks should pass

More details can be found in the pull request guide

adamalston avatar Jun 16 '25 13:06 adamalston

Deploy Preview for v11-carbon-web-components ready!

Name Link
Latest commit ba89a136a61855c10dee60b241e4996674f6a86d
Latest deploy log https://app.netlify.com/projects/v11-carbon-web-components/deploys/685016cd945c8a0008436a58
Deploy Preview https://deploy-preview-19665--v11-carbon-web-components.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify[bot] avatar Jun 16 '25 13:06 netlify[bot]

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
Latest commit ba89a136a61855c10dee60b241e4996674f6a86d
Latest deploy log https://app.netlify.com/projects/v11-carbon-react/deploys/685016cd22facf0008492603
Deploy Preview https://deploy-preview-19665--v11-carbon-react.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify[bot] avatar Jun 16 '25 13:06 netlify[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.68%. Comparing base (8536bb5) to head (ba89a13). Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19665      +/-   ##
==========================================
+ Coverage   84.67%   84.68%   +0.01%     
==========================================
  Files         373      372       -1     
  Lines       14723    14718       -5     
  Branches     4850     4855       +5     
==========================================
- Hits        12466    12464       -2     
+ Misses       2107     2103       -4     
- Partials      150      151       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jun 16 '25 13:06 codecov[bot]

No one answered the question in the TODO so I'll just delete it.

adamalston avatar Jun 18 '25 13:06 adamalston

Hey there! v11.85.0 was just released that references this issue/PR.

carbon-automation[bot] avatar Jun 18 '25 20:06 carbon-automation[bot]